feat: cast between Binary/LargeBinary and FixedSizeBinary
#3961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
reviewed
Mar 27, 2023
arrow-cast/src/cast.rs
Outdated
Comment on lines
3446
to
3450
| if is_binary && offsets > i32::MAX as i64 { | ||
| return Err(ArrowError::ComputeError( | ||
| "Cast from FixedSizeBinary to Binary would overflow".to_string(), | ||
| )); | ||
| } |
There was a problem hiding this comment.
Isn't this also used to LargeBinaryArray?
arrow-cast/src/cast.rs
Outdated
| /// If the target one is too large for the source array it will return an Error. | ||
| fn cast_fixed_size_binary_to_binary<O: OffsetSizeTrait>( | ||
| array: &dyn Array, | ||
| to_type: &DataType, |
There was a problem hiding this comment.
to_type looks redundant as it is known GenericBinaryType<O>.
tustvold
reviewed
Mar 28, 2023
arrow-cast/src/cast.rs
Outdated
Comment on lines
3413
to
3416
| let array = array | ||
| .as_any() | ||
| .downcast_ref::<GenericBinaryArray<O>>() | ||
| .unwrap(); |
There was a problem hiding this comment.
Suggested change
| let array = array | |
| .as_any() | |
| .downcast_ref::<GenericBinaryArray<O>>() | |
| .unwrap(); | |
| let array = array.as_binary::<O>(); |
arrow-cast/src/cast.rs
Outdated
|
|
||
| let offsets: i128 = byte_width as i128 * array.len() as i128; | ||
|
|
||
| let is_binary = matches!(to_type, DataType::Binary); |
There was a problem hiding this comment.
Could we change this to match on GenericBinaryType<O>::DATA_TYPE instead
arrow-cast/src/cast.rs
Outdated
| let a1 = Arc::new(FixedSizeBinaryArray::from(binary_data.clone())) as ArrayRef; | ||
|
|
||
| let array_ref = cast(&a1, &DataType::Binary).unwrap(); | ||
| let down_cast = array_ref.as_any().downcast_ref::<BinaryArray>().unwrap(); |
There was a problem hiding this comment.
Suggested change
| let down_cast = array_ref.as_any().downcast_ref::<BinaryArray>().unwrap(); | |
| let down_cast = array_ref.as_binary::<i32>(); |
arrow-cast/src/cast.rs
Outdated
Comment on lines
5431
to
5434
| let down_cast = array_ref | ||
| .as_any() | ||
| .downcast_ref::<LargeBinaryArray>() | ||
| .unwrap(); |
There was a problem hiding this comment.
Suggested change
| let down_cast = array_ref | |
| .as_any() | |
| .downcast_ref::<LargeBinaryArray>() | |
| .unwrap(); | |
| let down_cast = array_ref.as_binary::<i64>(); |
arrow-cast/src/cast.rs
Outdated
| if array.is_null(i) { | ||
| builder.append_null(); | ||
| } else { | ||
| builder.append_value(array.value(i))?; |
There was a problem hiding this comment.
I think this should handle CastOptions::safe and insert nulls instead of erroring if safe = true
viirya
reviewed
Mar 28, 2023
arrow-cast/src/cast.rs
Outdated
Comment on lines
3448
to
3453
| "Cast from FixedSizeBinary to Binary would overflow".to_string(), | ||
| )); | ||
| } else if !is_binary && offsets > i64::MAX as i128 { | ||
| return Err(ArrowError::ComputeError( | ||
| "Cast from FixedSizeBinary to LargeBinary would overflow".to_string(), | ||
| )); |
There was a problem hiding this comment.
The error message can be more specific. E.g., Cannot cast the FixedSizeBinary to Binary because exceeding maximum offset of Binary.
kazuyukitanimura
approved these changes
Mar 29, 2023
tustvold
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3826
Rationale for this change
What changes are included in this PR?
Support cast between
Binary/LargeBinaryandFixedSizeBinaryAre there any user-facing changes?