Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump github.com/substrait-io/substrait-go/v3 from 3.6.0 to 3.7.0 #287

Merged
merged 2 commits into from
Feb 18, 2025
Merged

chore: Bump github.com/substrait-io/substrait-go/v3 from 3.6.0 to 3.7.0 #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c0a682
chore: Bump github.com/substrait-io/substrait-go/v3 from 3.6.0 to 3.7.0
dependabot[bot] Feb 17, 2025
dbc0bf1
fix breaking substrait-go change
zeroshade Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion arrow/compute/exprs/builders.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ import (
// Arrow Extension registry and the default collection of substrait extensions
// from the Substrait-go repo.
func NewDefaultExtensionSet() ExtensionIDSet {
return NewExtensionSetDefault(expr.NewEmptyExtensionRegistry(&extensions.DefaultCollection))
return NewExtensionSetDefault(
expr.NewEmptyExtensionRegistry(extensions.GetDefaultCollectionWithNoError()))
}

// NewScalarCall constructs a substrait ScalarFunction expression with the provided
Expand Down
5 changes: 3 additions & 2 deletions arrow/compute/exprs/exec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ func GetExtensionIDSet(ctx context.Context) ExtensionIDSet {
v, ok := ctx.Value(extCtxKey{}).(ExtensionIDSet)
if !ok {
return NewExtensionSet(
expr.NewEmptyExtensionRegistry(&extensions.DefaultCollection),
expr.NewEmptyExtensionRegistry(extensions.GetDefaultCollectionWithNoError()),
GetExtensionRegistry(ctx))
}
return v
Expand Down Expand Up @@ -434,7 +434,8 @@ func ExecuteScalarSubstrait(ctx context.Context, expression *expr.Extended, part
}

reg := GetExtensionRegistry(ctx)
set := NewExtensionSet(expr.NewExtensionRegistry(expression.Extensions, &extensions.DefaultCollection), reg)
set := NewExtensionSet(expr.NewExtensionRegistry(expression.Extensions,
extensions.GetDefaultCollectionWithNoError()), reg)
sc, err := ToArrowSchema(expression.BaseSchema, set)
if err != nil {
return nil, err
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ require (
github.com/pterm/pterm v0.12.80
github.com/stoewer/go-strcase v1.3.0
github.com/stretchr/testify v1.10.0
github.com/substrait-io/substrait-go/v3 v3.6.0
github.com/substrait-io/substrait-go/v3 v3.7.0
github.com/tidwall/sjson v1.2.5
github.com/zeebo/xxh3 v1.0.2
golang.org/x/exp v0.0.0-20240909161429-701f63a606c0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,8 @@ github.com/stretchr/testify v1.10.0 h1:Xv5erBjTwe/5IxqUQTdXv5kgmIvbHo3QQyRwhJsOf
github.com/stretchr/testify v1.10.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY=
github.com/substrait-io/substrait v0.66.1-0.20250205013839-a30b3e2d7ec6 h1:XqtxwYFCjS4L0o1QD4ipGHCuFG94U0f6BeldbilGQjU=
github.com/substrait-io/substrait v0.66.1-0.20250205013839-a30b3e2d7ec6/go.mod h1:MPFNw6sToJgpD5Z2rj0rQrdP/Oq8HG7Z2t3CAEHtkHw=
github.com/substrait-io/substrait-go/v3 v3.6.0 h1:t+mb4WskugKDVRqAZvV6Y0m34AQcDrd0cZ3NOXDcUjU=
github.com/substrait-io/substrait-go/v3 v3.6.0/go.mod h1:VG7jCqtUm28bSngHwq86FywtU74knJ25LNX63SZ53+E=
github.com/substrait-io/substrait-go/v3 v3.7.0 h1:rBxnPXTtxgPJTLpMvZgcEXuVyzmO0SkM2EpEUEvdN5s=
github.com/substrait-io/substrait-go/v3 v3.7.0/go.mod h1:VG7jCqtUm28bSngHwq86FywtU74knJ25LNX63SZ53+E=
github.com/tidwall/gjson v1.14.2 h1:6BBkirS0rAHjumnjHF6qgy5d2YAJ1TLIaFE2lzfOLqo=
github.com/tidwall/gjson v1.14.2/go.mod h1:/wbyibRr2FHMks5tjHJ5F8dMZh3AcwJEMf5vlfC0lxk=
github.com/tidwall/match v1.1.1 h1:+Ho715JplO36QYgwN9PGYNhgZvoUSc9X2c80KVTi+GA=
Expand Down
Loading