-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(rust): bump arrow
and datafusion
#2518
Conversation
Bumps the datafusion group in /rust with 2 updates: [datafusion](https://github.com/apache/datafusion) and [datafusion-substrait](https://github.com/apache/datafusion). Updates `datafusion` from 44.0.0 to 45.0.0 - [Changelog](https://github.com/apache/datafusion/blob/main/CHANGELOG.md) - [Commits](apache/datafusion@44.0.0...45.0.0) Updates `datafusion-substrait` from 44.0.0 to 45.0.0 - [Changelog](https://github.com/apache/datafusion/blob/main/CHANGELOG.md) - [Commits](apache/datafusion@44.0.0...45.0.0) --- updated-dependencies: - dependency-name: datafusion dependency-type: direct:production update-type: version-update:semver-major dependency-group: datafusion - dependency-name: datafusion-substrait dependency-type: direct:production update-type: version-update:semver-major dependency-group: datafusion ... Signed-off-by: dependabot[bot] <[email protected]>
"ffi", | ||
] } | ||
arrow-buffer = { version = "53.1.0", default-features = false } | ||
arrow-schema = { version = "53.1.0", default-features = false } | ||
arrow-select = { version = "53.4.0", default-features = false } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get a release of arrow-adbc
that uses Datafusion 44 and Arrow 53.3.0 (which are the arrow versions used by df 44)?
I can send that PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This crate is still unpublished on crates.io, but the last release (16) was based on Datafusion 44 and Arrow 53:
arrow-adbc/rust/driver/datafusion/Cargo.toml
Lines 31 to 32 in 05c33a7
datafusion = "44.0.0" | |
datafusion-substrait = "44.0.0" |
Lines 38 to 43 in 05c33a7
arrow-array = { version = "53.1.0", default-features = false, features = [ | |
"ffi", | |
] } | |
arrow-buffer = { version = "53.1.0", default-features = false } | |
arrow-schema = { version = "53.1.0", default-features = false } | |
arrow-select = { version = "53.1.0", default-features = false } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to release more frequently here to keep up with the upstream project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, but not necessarily for all updates; users are only blocked when they want to bump their major versions of these crates and this driver is not released for that major version yet.
Given that this is not on crates.io yet, it doesn't really matter (because users are most likely pulling and building directly from git).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, event if I use 53.3.0
specifically, arrow-adbc
won't force 53.1.0
because the only difference is the minor version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we hold off given the regression in 54.1? https://lists.apache.org/thread/znszlgdkbm5mk4o7ydp5rkdp62kj6hmm |
I don't think we have to hold off, by merging this we are unblocking anyone waiting to use this with Datafusion 45. We can then bump the minor/patch versions later. |
ah, it's been years since I've touched cargo. So cargo is fine if we're on 53.1 and you're on 53.2, but if you're on 54, it won't unify the dependencies? (Makes sense honestly.) |
Closes #2516.