Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rust): publish driver crates #2480

Merged
merged 3 commits into from
Jan 23, 2025
Merged

chore(rust): publish driver crates #2480

merged 3 commits into from
Jan 23, 2025

Conversation

mbrobbel
Copy link
Contributor

Closes #2477.

@github-actions github-actions bot added this to the ADBC Libraries 17 milestone Jan 22, 2025
@mbrobbel mbrobbel mentioned this pull request Jan 22, 2025
Closed
@mbrobbel mbrobbel changed the title chore(rust,release): publish driver crates chore(rust): publish driver crates Jan 22, 2025
lidavidm
lidavidm reviewed Jan 22, 2025
View reviewed changes
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update https://github.com/apache/arrow-adbc/blob/main/dev/release/utils-prepare.sh to bump the versions, too

@lidavidm
Copy link
Member

Oh wait. workspace = true...will this publish correctly?

@mbrobbel
Copy link
Contributor Author

It works if the script also bumps the workspace adbc_core dependency version to match the workspace version.

lidavidm
lidavidm approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lidavidm lidavidm merged commit 6a7d501 into apache:main Jan 23, 2025
6 checks passed
@mbrobbel mbrobbel deleted the publish-workspace branch January 23, 2025 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidavidm lidavidm lidavidm approved these changes

@kou kou Awaiting requested review from kou kou is a code owner

@wjones127 wjones127 Awaiting requested review from wjones127 wjones127 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ADBC Libraries 17
Development

Successfully merging this pull request may close these issues.

dev/release: publish other Rust crates
2 participants
@mbrobbel @lidavidm