Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): ensure wheels are built with older manylinux #2351

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

lidavidm
Copy link
Member

@lidavidm lidavidm commented Dec 4, 2024

  • Build binaries separately using an older glibc.
  • Use a separate image with a new docker to run cibuildwheel.

Fixes #2350.

@lidavidm lidavidm force-pushed the gh-2350 branch 2 times, most recently from 4ee5866 to 6b29c7d Compare December 4, 2024 02:52
@lidavidm lidavidm marked this pull request as ready for review December 4, 2024 06:15
@github-actions github-actions bot modified the milestone: ADBC Libraries 16 Dec 4, 2024
@WillAyd
Copy link
Contributor

WillAyd commented Dec 4, 2024

Looks good. Slightly tangential question - is there a reason we choose to do this all via docker instead of using the cibuildwheel service?

@lidavidm
Copy link
Member Author

lidavidm commented Dec 4, 2024

I chose docker mostly because then I can also run the exact same setup locally

@paleolimbot
Copy link
Member

nanoarrow is admittedly much less complex, but we use cibuildwheel using mostly defaults, with https://github.com/apache/arrow-nanoarrow/blob/e54b7df525fa1d310a96687bd99902823402b26c/ci/scripts/test-python-wheels.sh#L44-L51 to test locally.

@lidavidm lidavidm merged commit 0b46c8d into apache:main Dec 5, 2024
65 checks passed
@lidavidm lidavidm deleted the gh-2350 branch December 5, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to install adbc-driver-postgresql==1.3.0
4 participants