Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(go/adbc/driver/snowflake): add support for a client config file #2197

Merged
merged 2 commits into from
Oct 2, 2024
Merged

feat(go/adbc/driver/snowflake): add support for a client config file #2197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0dad82a
add support for a client config file
Sep 27, 2024
f9c2c24
fix docs link
Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/source/driver/snowflake.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,6 +446,10 @@ These options map 1:1 with the Snowflake `Config object <https://pkg.go.dev/gith
disabled by setting this to ``true``. Value should be either ``true``
or ``false``.

``adbc.snowflake.sql.client_option.config_file``
Specifies the location of the client configuration JSON file. See the
[Snowflake Go docs](https://github.com/snowflakedb/gosnowflake/blob/a26ac8a1b9a0dda854ac5db9c2c145f79d5ac4c0/doc.go#L130) for more details.

``adbc.snowflake.sql.client_option.tracing``
Set the logging level

Expand Down
2 changes: 2 additions & 0 deletions go/adbc/driver/snowflake/driver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,8 @@ const (
OptionDisableTelemetry = "adbc.snowflake.sql.client_option.disable_telemetry"
// snowflake driver logging level
OptionLogTracing = "adbc.snowflake.sql.client_option.tracing"
// snowflake driver client logging config file
OptionClientConfigFile = "adbc.snowflake.sql.client_option.config_file"
// When true, the MFA token is cached in the credential manager. True by default
// on Windows/OSX, false for Linux
OptionClientRequestMFAToken = "adbc.snowflake.sql.client_option.cache_mfa_token"
Expand Down
14 changes: 14 additions & 0 deletions go/adbc/driver/snowflake/driver_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2144,3 +2144,17 @@ func (suite *SnowflakeTests) TestChangeDatabaseAndGetObjects() {
_, err2 := suite.cnxn.GetObjects(suite.ctx, adbc.ObjectDepthAll, &newCatalog, &cfg.Schema, &getObjectsTable, nil, nil)
suite.NoError(err2)
}

func (suite *SnowflakeTests) TestGetSetClientConfigFile() {
file := "fileNameJustForTest.json"
options := map[string]string{
driver.OptionClientConfigFile: file,
}
getSetDB, ok := suite.db.(adbc.GetSetOptions)
suite.True(ok)
err := suite.db.SetOptions(options)
suite.NoError(err)
result, err := getSetDB.GetOption(driver.OptionClientConfigFile)
suite.NoError(err)
suite.True(file == result)
}
4 changes: 4 additions & 0 deletions go/adbc/driver/snowflake/snowflake_database.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,8 @@ func (d *databaseImpl) GetOption(key string) (string, error) {
return adbc.OptionValueDisabled, nil
case OptionLogTracing:
return d.cfg.Tracing, nil
case OptionClientConfigFile:
return d.cfg.ClientConfigFile, nil
case OptionUseHighPrecision:
if d.useHighPrecision {
return adbc.OptionValueEnabled, nil
Expand Down Expand Up @@ -415,6 +417,8 @@ func (d *databaseImpl) SetOptions(cnOptions map[string]string) error {
}
case OptionLogTracing:
d.cfg.Tracing = v
case OptionClientConfigFile:
d.cfg.ClientConfigFile = v
case OptionUseHighPrecision:
switch v {
case adbc.OptionValueEnabled:
Expand Down
Loading