Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(csharp/src/Drivers/Apache/Spark): extend SQL type name parsing for all types #1911

Merged
merged 10 commits into from
Jun 13, 2024
Merged

feat(csharp/src/Drivers/Apache/Spark): extend SQL type name parsing for all types #1911

merged 10 commits into from
Jun 13, 2024

Conversation

birschick-bq
Copy link
Contributor

Extend SQL type name parsing to all possible types for Spark.

Additional support for:

  • ARRAY
  • BIGINT
  • BINARY
  • BOOLEAN
  • DATE
  • DOUBLE
  • FLOAT
  • INTEGER
  • JAVA_OBJECT
  • SMALLINT
  • STRUCT
  • TIMESTAMP
  • TIMESTAMP_WITH_TIMEZONE
  • TINYINT

Add extensive tests for SQL type name parsing

@birschick-bq birschick-bq changed the title feat(csharp/Drivers/Apache/Spark): extend SQL type name parsing for all types feat(csharp/src/Drivers/Apache/Spark): extend SQL type name parsing for all types Jun 9, 2024
@birschick-bq birschick-bq requested a review from ryan-syed June 11, 2024 17:13
@birschick-bq birschick-bq marked this pull request as ready for review June 12, 2024 21:13
@github-actions github-actions bot added this to the ADBC Libraries 13 milestone Jun 12, 2024
CurtHagenlocher
CurtHagenlocher approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@CurtHagenlocher CurtHagenlocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@CurtHagenlocher CurtHagenlocher merged commit 319ba01 into apache:main Jun 13, 2024
6 checks passed
@birschick-bq birschick-bq deleted the dev/birschick-bq/get-type-name-2 branch October 15, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CurtHagenlocher CurtHagenlocher CurtHagenlocher approved these changes

@ryan-syed ryan-syed Awaiting requested review from ryan-syed

@lidavidm lidavidm Awaiting requested review from lidavidm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ADBC Libraries 13
Development

Successfully merging this pull request may close these issues.
3 participants
@birschick-bq @CurtHagenlocher @ryan-syed