Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(csharp/src/Drivers/Apache): improve GetObjects metadata returned for columns #1884

Merged
merged 10 commits into from
May 31, 2024
Merged

feat(csharp/src/Drivers/Apache): improve GetObjects metadata returned for columns #1884

merged 10 commits into from
May 31, 2024

Conversation

birschick-bq
Copy link
Contributor

Improve the amount and quality of column metadata returned to the call to GetObjects where depth is All for the Spark driver.

  • Add an enumeration to provide identifiers for the Spark-specific data types (based on JDBC Types constants).
  • Improve metadata for column data types, precision and scale (for DECIMAL/NUMERIC types), etc.
  • Improve test to ensure new metadata is present.

@birschick-bq birschick-bq marked this pull request as ready for review May 27, 2024 20:27
@birschick-bq
Copy link
Contributor Author

@ryan-syed Please review if you have a chance.

@github-actions github-actions bot added this to the ADBC Libraries 13 milestone May 28, 2024
@birschick-bq
Copy link
Contributor Author

@CurtHagenlocher - If you have some time, could you review this PR. It resolves an issue for integration into ADBC data source.

@birschick-bq
Copy link
Contributor Author

@CurtHagenlocher Made the change to move the using line to the end.

@CurtHagenlocher CurtHagenlocher merged commit 0544d3b into apache:main May 31, 2024
6 checks passed
@birschick-bq birschick-bq deleted the dev/birschick-bq/get-objects-better-metadata branch June 4, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryan-syed ryan-syed ryan-syed left review comments

@CurtHagenlocher CurtHagenlocher CurtHagenlocher approved these changes

@lidavidm lidavidm Awaiting requested review from lidavidm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ADBC Libraries 13
Development

Successfully merging this pull request may close these issues.
3 participants
@birschick-bq @CurtHagenlocher @ryan-syed