feat(csharp/src/Apache.Arrow.Adbc): Cleanup use of List<T> in APIs and implementation #1761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidhcoe, I'd appreciate your review on this. |
CurtHagenlocher
commented
Apr 24, 2024
| #if NET5_0_OR_GREATER | ||
| List<T> concreteList = list as List<T>; | ||
| if (concreteList != null) { return CollectionsMarshal.AsSpan(concreteList); } | ||
| T[] array = list as T[]; |
There was a problem hiding this comment.
oh, hmm, this doesn't need to be in the #if.
|
This looks good @CurtHagenlocher and brings things more in line with the pattern that was established with the IReadOnlyDictionary parameters and options. |
cocoa-xu
pushed a commit
to meowcraft-dev/arrow-adbc
that referenced
this pull request
May 8, 2024
…d implementation (apache#1761) Replaces the use of `List<T>` in most API signatures with `IReadOnlyList<T>` to allow many different types of collections (such as arrays) to be passed in. Replaces the use of `List<T>` in many implementations with `T[]` for performance and readability benefits. Closes apache#1757
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the use of
List<T>in most API signatures withIReadOnlyList<T>to allow many different types of collections (such as arrays) to be passed in.Replaces the use of
List<T>in many implementations withT[]for performance and readability benefits.Closes #1757