ci(rust): only use allowed actions #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrobbel
requested review from
lidavidm,
zeroshade and
wjones127
as code owners
|
I think you just need to add Cargo.lock to https://github.com/apache/arrow-adbc/blob/main/dev/release/rat_exclude_files.txt |
lidavidm
approved these changes
Apr 23, 2024
Comment on lines
+76
to
+77
| - name: Rustfmt | ||
| run: cargo fmt --all -- --check |
There was a problem hiding this comment.
Ideally this would be in pre-commit?
lidavidm
approved these changes
Apr 23, 2024
alexandreyc
reviewed
Apr 23, 2024
| @@ -0,0 +1,799 @@ | |||
| # This file is automatically @generated by Cargo. | |||
There was a problem hiding this comment.
I'm not totally convinced that Cargo.lock must be checked-in for libraries.
After checking some of the most popular crates, almost none of them have it (arrow-rs neither).
On the other hand, I can't find any good reason to not have it 😃
There was a problem hiding this comment.
lidavidm
pushed a commit
that referenced
this pull request
Apr 23, 2024
As suggested in #1749 (comment).
davidhcoe
pushed a commit
to davidhcoe/arrow-adbc
that referenced
this pull request
Apr 25, 2024
Update Rust workflow to only use Apache allowed actions. This also adds `Cargo.lock` (used in cache key) to the Rust workspace following [this recommendation](https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html), and fixes some doc warnings.
davidhcoe
pushed a commit
to davidhcoe/arrow-adbc
that referenced
this pull request
Apr 25, 2024
As suggested in apache#1749 (comment).
cocoa-xu
pushed a commit
to meowcraft-dev/arrow-adbc
that referenced
this pull request
May 8, 2024
Update Rust workflow to only use Apache allowed actions. This also adds `Cargo.lock` (used in cache key) to the Rust workspace following [this recommendation](https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html), and fixes some doc warnings.
cocoa-xu
pushed a commit
to meowcraft-dev/arrow-adbc
that referenced
this pull request
May 8, 2024
As suggested in apache#1749 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Rust workflow to only use Apache allowed actions. This also adds
Cargo.lock(used in cache key) to the Rust workspace following this recommendation, and fixes some doc warnings.