Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduced SQL calls in GetObjects to one and added prefixing DbNam… #1351

Closed
wants to merge 1 commit into from
Closed

Reduced SQL calls in GetObjects to one and added prefixing DbNam… #1351

wants to merge 1 commit into from

Conversation

ryan-syed
Copy link
Contributor

@ryan-syed ryan-syed commented Dec 13, 2023 •
edited
Loading

Changes:

  • Reduced SQL calls by making only one SQL call based on the ObjectsDepth and using that data to populate all the previous depth information
  • Modified tests to check the table type returned
  • GetObjects populates the MetadataRecords by making the necessary SQL call based on ObjectsDepth
  • Modified the logic of GetObjects Init to pass MetadataRecords in getObjectsDbSchemas and getObjectsTables
image

@ryan-syed
fix: Reduced SQL calls in GetObjects to one and added prefixing DbNam…
b99c6fd 
…e for INFORMATION_SCHEMA calls

Additional changes:
* Reduced SQL calls by making only one SQL call based on the ObjectsDepth and using that data to populate all the previous depth information
* Modified tests to check the table type returned
* GetObjects populates the MetadataRecords by making the necessary SQL call based on ObjectsDepth
* Modified the logic of GetObjects Init to pass MetadataRecords in getObjectsDbSchemas and getObjectsTables
@github-actions GitHub Actions
Copy link

⚠️ Please follow the Conventional Commits format in CONTRIBUTING.md for PR titles.

@github-actions github-actions bot added this to the ADBC Libraries 0.9.0 milestone Dec 13, 2023
This was referenced Dec 13, 2023
Closed
Merged
@ryan-syed
Copy link
Contributor Author

Similar to PR: #1352, except for populateMetadata, prepareDbSchemasSQL, prepareTablesSQL, and prepareColumnsSQL.

The implementation is based on proposal: https://github.com/apache/arrow-adbc/issues/1332##Proposal and improving existing API implementation.

@lidavidm lidavidm removed this from the ADBC Libraries 0.9.0 milestone Dec 19, 2023
@ryan-syed ryan-syed closed this Dec 23, 2023
@lidavidm
Copy link
Member

lidavidm commented Jan 2, 2024

@ryan-syed were you still planning on working on this? I just removed it from the milestone because I don't think I can review it before trying to release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeroshade zeroshade Awaiting requested review from zeroshade zeroshade will be requested when the pull request is marked ready for review zeroshade is a code owner

@CurtHagenlocher CurtHagenlocher Awaiting requested review from CurtHagenlocher CurtHagenlocher will be requested when the pull request is marked ready for review CurtHagenlocher is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryan-syed @lidavidm