Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(log-rotate): replace string.sub with string.byte #9984

Merged
merged 1 commit into from
Aug 14, 2023
Merged

perf(log-rotate): replace string.sub with string.byte #9984

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions apisix/plugins/log-rotate.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ local os_remove = os.remove
local os_rename = os.rename
local str_sub = string.sub
local str_format = string.format
local str_byte = string.byte
local ngx_sleep = require("apisix.core.utils").sleep
local string_rfind = require("pl.stringx").rfind
local local_conf
Expand All @@ -48,6 +49,7 @@ local default_logs
local enable_compression = false
local DEFAULT_ACCESS_LOG_FILENAME = "access.log"
local DEFAULT_ERROR_LOG_FILENAME = "error.log"
local SLASH_BYTE = str_byte("/")

local schema = {
type = "object",
Expand Down Expand Up @@ -88,9 +90,8 @@ local function get_log_path_info(file_type)
local prefix = ngx.config.prefix()

if conf_path then
local root = str_sub(conf_path, 1, 1)
-- relative path
if root ~= "/" then
if str_byte(conf_path) ~= SLASH_BYTE then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this more efficient?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refer https://moonbingbing.gitbooks.io/openresty-best-practices/content/lua/string_library.html

image

conf_path = prefix .. conf_path
end
local n = string_rfind(conf_path, "/")
Expand Down