Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: syslog double encoding message #9402

Closed

Conversation

shreemaan-abhishek
Copy link
Contributor

Description

Fixes #8276

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@monkeyDluffy6017
Copy link
Contributor

Need test cases

@Sn0rt
Copy link
Contributor

Sn0rt commented May 8, 2023

@shreemaan-abhishek currently. the syslog plugin doesn't work.

this PR maybe depend on #9425.

@shreemaan-abhishek
Copy link
Contributor Author

shreemaan-abhishek commented May 8, 2023

@shreemaan-abhishek currently. the syslog plugin doesn't work.

this PR maybe depend on #9425.

What exactly do you mean it does not work? 🤔 We checked it locally, right? And it was working fine, isn't it? 🤔🤔🤔

@shreemaan-abhishek
Copy link
Contributor Author

Need test cases

@monkeyDluffy6017 I could not understand what kind of extra test case is needed. I think the existing test cases are sufficient.

@Sn0rt
Copy link
Contributor

Sn0rt commented May 9, 2023

@shreemaan-abhishek I mean the syslog encoding error. so the log server such rsyslog can't receive the log entry.

aha. now your commit has been copy to #9425

@monkeyDluffy6017
Copy link
Contributor

@Sn0rt Should this pr be closed?

@Sn0rt
Copy link
Contributor

Sn0rt commented May 10, 2023

@Sn0rt Should this pr be closed?

sorry. I can't see the close button.

@shreemaan-abhishek shreemaan-abhishek deleted the fix/double-encoding branch May 30, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Logs are double encoded in init.lua of syslog plugin
3 participants