Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(openwhisk): ensure the request sent to a wrong host #7507

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

spacewander
Copy link
Member

Avoid test failures:
Failed test 't/plugin/openwhisk.t TEST 12: hit route (with wrong api_host) -
pattern "failed to process openwhisk action, err:" should match a line
in error.log
happened in CentOS 7 test.

Look like 127.0.0.0 is connectable in some environment.

Signed-off-by: spacewander [email protected]

Description

Fixes # (issue)

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

Avoid test failures:
Failed test 't/plugin/openwhisk.t TEST 12: hit route (with wrong api_host) -
pattern "failed to process openwhisk action, err:" should match a line
in error.log
happened in CentOS 7 test.

Look like 127.0.0.0 is connectable in some environment.

Signed-off-by: spacewander <[email protected]>
@spacewander spacewander marked this pull request as ready for review July 20, 2022 15:09
@tzssangglass
Copy link
Member

Look like 127.0.0.0 is connectable in some environment.

No wonder I can't reproduce it locally……

@bzp2010
Copy link
Contributor

bzp2010 commented Jul 20, 2022

Look like 127.0.0.0 is connectable in some environment.

@tzssangglass More strangely, APISIX Dashboard is in a similar situation today, where once it used 127.0.0.0 in a CLI test, it was always unconnectable, and in today's test, it became connectable. I'm not sure what's going on. 🤔

BTW, there is the PR apache/apisix-dashboard#2532

@spacewander spacewander merged commit 6451dd6 into apache:master Jul 21, 2022
spacewander added a commit to spacewander/incubator-apisix that referenced this pull request Aug 12, 2022
Avoid test failures:
Failed test 't/plugin/openwhisk.t TEST 12: hit route (with wrong api_host) -
pattern "failed to process openwhisk action, err:" should match a line
in error.log
happened in CentOS 7 test.

Look like 127.0.0.0 is connectable in some environment.

Signed-off-by: spacewander <[email protected]>
spacewander added a commit that referenced this pull request Aug 17, 2022
Avoid test failures:
Failed test 't/plugin/openwhisk.t TEST 12: hit route (with wrong api_host) -
pattern "failed to process openwhisk action, err:" should match a line
in error.log
happened in CentOS 7 test.

Look like 127.0.0.0 is connectable in some environment.

Signed-off-by: spacewander <[email protected]>
Liu-Junlin pushed a commit to Liu-Junlin/apisix that referenced this pull request Nov 4, 2022
Avoid test failures:
Failed test 't/plugin/openwhisk.t TEST 12: hit route (with wrong api_host) -
pattern "failed to process openwhisk action, err:" should match a line
in error.log
happened in CentOS 7 test.

Look like 127.0.0.0 is connectable in some environment.

Signed-off-by: spacewander <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants