Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust the execution priority of request-id to fix opentelemetry has no request id #7281

Merged
merged 7 commits into from
Jun 22, 2022
Merged

fix: adjust the execution priority of request-id to fix opentelemetry has no request id #7281

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2b30150
feat: adjust the execution priority after the request-id
Jun 20, 2022
061e917
feat: adjust the execution priority after the request-id
Jun 20, 2022
f8fa0a9
feat: adjust the execution priority after the request-id
Jun 21, 2022
9bcdec0
Merge branch 'apache:master' into master
jagerzhang Jun 21, 2022
9480a3c
fix: adjust the execution priority of request-id to fix opentelemetry…
Jun 21, 2022
31e45c7
Merge branch 'master' of https://github.com/jagerzhang/apisix
Jun 21, 2022
4c07de9
fix: adjust the execution priority of request-id to fix opentelemetry…
Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apisix/plugins/opentelemetry.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ local schema = {

local _M = {
version = 0.1,
priority = 12009,
priority = 11009,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's not a good idea to set it adjacent to the request-id plugin. It's not extendable if we need to insert another plugin between them in the future.

Copy link
Contributor Author

@jagerzhang jagerzhang Jun 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's not a good idea to set it adjacent to the request-id plugin. It's not extendable if we need to insert another plugin between them in the future.

OK, already change to 11005

name = plugin_name,
schema = schema,
attr_schema = attr_schema,
Expand Down