docs: replace all apisix-openresty to apisix-base #6998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oil-oil There are several conflicts need to be fixed. |
Okay, I forgot to sync the upstream master branch when I updated 🤓 . |
guitu168
reviewed
May 7, 2022
| @@ -564,7 +564,7 @@ The following should be considered when setting the `hash_on` value: | |||
| - When set to `vars_combinations`, the `key` is required. The value of the key can be a combination of any of the [Nginx variables](http://nginx.org/en/docs/varindex.html) like `$request_uri$remote_addr`. | |||
| - When no value is set for either `hash_on` or `key`, the key defaults to `remote_addr`. | |||
|
|
|||
| The features described below requires APISIX to be run on [APISIX-OpenResty](./how-to-build.md#step-6-build-openresty-for-apache-apisix): | |||
| The features described below requires APISIX to be run on [APISIX-Base](./how-to-build.md#step-6-build-openresty-for-apache-apisix): | |||
There was a problem hiding this comment.
There is no how-to-build.md#step-6-build-openresty-for-apache-apisix in the latest how-to-build document, we need to change it to another link. We can add step 6 to the FAQ document. Or do we have any other option?
There was a problem hiding this comment.
Yes, @oil-oil please check https://apisix.apache.org/docs/apisix/next/how-to-build
moonming
approved these changes
May 7, 2022
|
That will be great if we can add GitHub repo link for apisix-base |
tzssangglass
approved these changes
May 7, 2022
Liu-Junlin
pushed a commit
to Liu-Junlin/apisix
that referenced
this pull request
May 20, 2022
spacewander
pushed a commit
that referenced
this pull request
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6983
Checklist