Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(nacos): enrich nacos test case #6567

Merged
merged 1 commit into from Mar 11, 2022
Merged

test(nacos): enrich nacos test case #6567

merged 1 commit into from Mar 11, 2022

Conversation

leslie-tsang
Copy link
Member

@leslie-tsang leslie-tsang commented Mar 10, 2022 •
edited
Loading

What this PR does / why we need it:

resolve #6522

Now the test case will change the nacos server default password to verify if the auth work as expected.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@leslie-tsang leslie-tsang marked this pull request as ready for review March 11, 2022 01:43
@leslie-tsang leslie-tsang mentioned this pull request Mar 11, 2022
Closed
@spacewander spacewander merged commit 0c2ba4b into apache:master Mar 11, 2022
@leslie-tsang leslie-tsang deleted the chore/enrich-nacos-test-case branch March 11, 2022 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacewander spacewander spacewander approved these changes

@tzssangglass tzssangglass tzssangglass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: nacos discovery config valid error when using $ in password symbol in config.yaml
3 participants
@leslie-tsang @spacewander @tzssangglass