feat: support for configuring the number of etcd health check retries #6322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzssangglass
changed the title
Co-authored-by: tzssangglass <[email protected]>
Co-authored-by: tzssangglass <[email protected]>
spacewander
reviewed
Feb 15, 2022
conf/config-default.yaml
Outdated
| @@ -274,6 +274,7 @@ etcd: | |||
| timeout: 30 # 30 seconds | |||
| #resync_delay: 5 # when sync failed and a rest is needed, resync after the configured seconds plus 50% random jitter | |||
| #health_check_timeout: 10 # etcd retry the unhealthy nodes after the configured seconds | |||
| health_check_retry: 2 # etcd retry time, defalut 2 | |||
There was a problem hiding this comment.
We should emphasize that the retry time only affects the health check in the comment.
There was a problem hiding this comment.
thx, i will specify it
Co-authored-by: 罗泽轩 <[email protected]>
tzssangglass
previously approved these changes
Feb 16, 2022
…ix into feature/etcd_retry_time Conflicts: conf/config-default.yaml
thx, i will remove the whitespace |
starsz
reviewed
Feb 16, 2022
There was a problem hiding this comment.
Hi @tylitianrui.
It's better to add test case in t/cli/test_etcd.sh to cover it.
spacewander
approved these changes
Feb 16, 2022
There was a problem hiding this comment.
Actually, the test case is in https://github.com/apache/apisix/blob/master/t/cli/test_etcd_healthcheck.sh.
I think it is too tough for the first contributor to add a test for it...
tokers
approved these changes
Feb 17, 2022
tzssangglass
approved these changes
Feb 17, 2022
starsz
approved these changes
Feb 17, 2022
shuaijinchao
approved these changes
Feb 17, 2022
hongbinhsu
pushed a commit
to fitphp/apix
that referenced
this pull request
Feb 23, 2022
* upstream: (52 commits) feat: add kubernetes discovery module (apache#4880) docs: fix For L7 proxy -> For L4 proxy (apache#6423) fix(deps): upgrade jsonschema to 0.9.8 (apache#6407) docs: translate Chinese to English in en clickhouse-logger (apache#6416) docs: add zh proxy-control.md&modify other doc error (apache#6346) docs: update public API relative usage (apache#6318) docs(cn): remove datadog from sidebar & fix doc lint conf (apache#6411) fix(request-validation): should not limit the urlencoded post args number (apache#6396) docs: fix configuration file typo (apache#6395) docs(extern-plugin): the implementation of runner (apache#6336) docs: polishing skywalking-logger plugin's docs (apache#6377) doc: adjust the directory structure of observability's documents (apache#6391) change(admin): empty nodes should be encoded as array (apache#6384) fix: should not limit the header number (apache#6379) ci: remove unnecessary tmate action (apache#6367) fix(opentelemetry): batch_span_processor export zero length spans (apache#6349) feat(graphql): support http get and post json request (apache#6343) feat: support for configuring the number of etcd health check retries (apache#6322) feat(wasm): support getting request body (apache#6325) fix(hmac-auth): hmac-auth plugin sort array param (apache#6314) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
related 5158. users can configure the time of retry
Pre-submission checklist: