Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nacos): add complex password support for nacos host_pattern match rule #6261

Merged
merged 3 commits into from Feb 9, 2022
Merged

fix(nacos): add complex password support for nacos host_pattern match rule #6261

merged 3 commits into from Feb 9, 2022

Conversation

leslie-tsang
Copy link
Member

What this PR does / why we need it:

fix #6206

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@leslie-tsang leslie-tsang marked this pull request as ready for review February 8, 2022 07:07
@leslie-tsang leslie-tsang changed the title fix: add complex password support for nacos host_pattern match rule fix(nacos): add complex password support for nacos host_pattern match rule Feb 8, 2022
@spacewander spacewander merged commit defafb1 into apache:master Feb 9, 2022
@leslie-tsang leslie-tsang deleted the bugfix/issue-6206 branch February 13, 2022 12:47
@Fengxq2014
Copy link

The new rules do not match $,if password contains $

@membphis
Copy link
Member

membphis commented Mar 2, 2022

The new rules do not match $,if password contains $

welcome to create a new issue, you think we need to fix it

@spacewander spacewander mentioned this pull request Mar 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacewander spacewander spacewander approved these changes

@membphis membphis membphis approved these changes

@bzp2010 bzp2010 bzp2010 approved these changes

@tzssangglass tzssangglass tzssangglass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: nacos discovery config valid error when using special character password symbol in config.yaml
6 participants
@leslie-tsang @Fengxq2014 @membphis @spacewander @bzp2010 @tzssangglass