feat: nacos discovery support group #4325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demogorgon314
force-pushed
the
nacos_discovery_support_group
branch
from
f936ebb to
b2bf3d4
Compare
spacewander
reviewed
May 28, 2021
| @@ -124,7 +124,7 @@ The formatted response as below: | |||
| "node": { | |||
There was a problem hiding this comment.
It would be better if we can add a table of "discovery args" to nacos.md like https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/limit-count.md#attributes
spacewander
approved these changes
May 28, 2021
spacewander
reviewed
May 31, 2021
Firstsawyou
approved these changes
May 31, 2021
tokers
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
nacos discovery support group
Pre-submission checklist: