-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(traffic-split): configure multiple "rules", the request will be confused between upstream #4092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equest is confused
Related issues: #4090 |
spacewander
requested changes
Apr 21, 2021
spacewander
approved these changes
Apr 21, 2021
The PR title is too long, @Firstsawyou could you simplify it? |
Ok, updated. |
tokers
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When the rules array object in the traffic-split plugin has multiple upstream conditions (weighted_upstreams + match), the request will be confused among multiple upstreams. The following example:
Test :
Match the upstream of the 1981 port and return the 1981 port number:
Matches the upstream of the 1982 port, and is expected to return the 1982 port number, but it actually hits the upstream of the 1981 and 1982 port:
Does not match the upstream of the plugin, the upstream of the default route, returns the 1980 port number:
This PR is used to fix the problem.
Pre-submission checklist: