bugfix: create the health checker in access phase, allow to call `y…
#1971
Conversation
…ield` function, the `healchecheck` need this when creating new object.
| end | ||
|
|
||
| if nodes_count > 1 then | ||
| local checker = fetch_healthchecker(up_conf, route, |
There was a problem hiding this comment.
I think it might be better to move the creation of health-checker object to the set_directly function，
Sometimes, I call the set_directly function directly in the plugin，proxy to another uptream instead of the configuration in the route.
There was a problem hiding this comment.
we can add this in new PR ^_^
|
@nic-chen @spacewander @moonming Do you have time to take a look at this PR? |
|
add some test cases for the changing? |
|
ping @membphis |
|
Wow, this is an old PR. I will process it when I have time. If any other guys want to handle this feature, please let me know, then you can continue this job. ^_^ |
|
I will take care of it. |
|
we can close this PR after the new PR is created ^_^ |
|
Surpassed by #3240 |
…ield` function,
the
healchecheckneed this when creating new object.What this PR does / why we need it:
as title.
In
balancerphase, it not supportyield, then we can not callresty.lock, here the source link: https://github.com/api7/lua-resty-healthcheck/blob/master/lib/resty/healthcheck.lua#L186so we need to create the health checker in another phase like
accesswhich is supportyield.#1851
Pre-submission checklist: