Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add apisix/plugin/limit-req to makefile #10959

Merged
merged 3 commits into from
Feb 26, 2024
Merged

fix: add apisix/plugin/limit-req to makefile #10959

merged 3 commits into from
Feb 26, 2024

Conversation

zll600
Copy link
Contributor

@zll600 zll600 commented Feb 23, 2024 •
edited
Loading

Description

This pr want to fix ci problem introduced by #10874

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@zll600 zll600 marked this pull request as ready for review February 23, 2024 08:23
@zll600 zll600 changed the title fix: install gawk explicitly fix: add apisix/plugin/limit-req to Makfile Feb 23, 2024
shreemaan-abhishek
shreemaan-abhishek reviewed Feb 23, 2024
View reviewed changes
membphis
membphis previously approved these changes Feb 23, 2024
View reviewed changes
@shreemaan-abhishek shreemaan-abhishek changed the title fix: add apisix/plugin/limit-req to Makfile fix: add apisix/plugin/limit-req to makefile Feb 26, 2024
@monkeyDluffy6017 monkeyDluffy6017 added the wait for update wait for the author's response in this issue/PR label Feb 26, 2024
@zll600
Copy link
Contributor Author

zll600 commented Feb 26, 2024

@monkeyDluffy6017 @shreemaan-abhishek PTAL

@shreemaan-abhishek shreemaan-abhishek merged commit 8324821 into apache:master Feb 26, 2024
44 checks passed
@zll600 zll600 mentioned this pull request Feb 27, 2024
Closed
5 tasks
@zll600 zll600 deleted the fix_cli_test branch March 18, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monkeyDluffy6017 monkeyDluffy6017 monkeyDluffy6017 approved these changes

@shreemaan-abhishek shreemaan-abhishek shreemaan-abhishek approved these changes

@membphis membphis Awaiting requested review from membphis

Assignees
No one assigned
Labels
user responded wait for update wait for the author's response in this issue/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zll600 @membphis @monkeyDluffy6017 @shreemaan-abhishek