Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ocsp-stapling plugin #10817

Merged
merged 31 commits into from
Jan 24, 2024
Merged

feat: add ocsp-stapling plugin #10817

merged 31 commits into from
Jan 24, 2024

Conversation

yuweizzz
Copy link
Contributor

@yuweizzz yuweizzz commented Jan 15, 2024

Description

Related: #10309

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@monkeyDluffy6017
Copy link
Contributor

Thanks for your contribution! we will check this later

@monkeyDluffy6017
Copy link
Contributor

Nice work!

@monkeyDluffy6017 monkeyDluffy6017 added the wait for update wait for the author's response in this issue/PR label Jan 18, 2024
@monkeyDluffy6017
Copy link
Contributor

@yuweizzz please make the ci pass

@monkeyDluffy6017
Copy link
Contributor

please merge the master branch

@yuweizzz
Copy link
Contributor Author

merged.

@monkeyDluffy6017 monkeyDluffy6017 merged commit fa3f220 into apache:master Jan 24, 2024
44 checks passed
@ssdr
Copy link

ssdr commented Oct 29, 2024

It seems that set_ocsp_resp is not correct when supporting multiple certificates.

end
local fin_pem_cert = value.cert
-- multiple certificates support.
if value.certs then
for i = 1, #value.certs do
local cert = value.certs[i]
local key = value.keys[i]
ok, err = radixtree_sni.set_pem_ssl_key(sni, cert, key)
if not ok then
return false, err
end
fin_pem_cert = cert
end
end
local ok, err = set_ocsp_resp(fin_pem_cert,
value.ocsp_stapling.skip_verify,
value.ocsp_stapling.cache_ttl)

@yuweizzz
Copy link
Contributor Author

It seems that set_ocsp_resp is not correct when supporting multiple certificates.

end
local fin_pem_cert = value.cert
-- multiple certificates support.
if value.certs then
for i = 1, #value.certs do
local cert = value.certs[i]
local key = value.keys[i]
ok, err = radixtree_sni.set_pem_ssl_key(sni, cert, key)
if not ok then
return false, err
end
fin_pem_cert = cert
end
end
local ok, err = set_ocsp_resp(fin_pem_cert,
value.ocsp_stapling.skip_verify,
value.ocsp_stapling.cache_ttl)

Could you provide the log info or reproduction steps and create a new issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user responded wait for update wait for the author's response in this issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants