fix: update opentelemetry.lua for envoy x-request-id format

[artlin760402]

Description

Remove all "-" to fulfill opentelemetry standard

Fixes #10239

Checklist

• I have explained the need for this PR and the problem it solves
• I have explained the changes or the new features added to this PR
• I have added tests corresponding to this change
• I have updated the documentation to reflect this change
• I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

[Revolyssup]

@artlin760402 the change looks good but I have a question. The request will have - in the system where it was created like istio, but apisix would send it to collector without the -. Wouldn't it be tricky to then correlate the requests because collector receives the trace_id as non hyphenated but the actual trace_id is hyphenated?

[artlin760402]

@artlin760402 the change looks good but I have a question. The request will have - in the system where it was created like istio, but apisix would send it to collector without the -. Wouldn't it be tricky to then correlate the requests because collector receives the trace_id as non hyphenated but the actual trace_id is hyphenated?

Yes it's a workaround solution for enterprise envoy environment. So it may needs extra serverless function plugin to overwrite header value, or the Devops might have to trace logs by manually remove hyphens...

[monkeyDluffy6017]

Please make the ci pass

[Revolyssup]

@artlin760402 Please fix the failing lint tests

[Sn0rt]

it looks very different .
BTW: I think your should add a test case for your feature.

[shreemaan-abhishek]

Directly removing hyphens from the trace-id isn't a correct way to fix the problem. If you want to fix the problem this way, you can use the serverless plugin to do it.

[artlin760402]

Directly removing hyphens from the trace-id isn't a correct way to fix the problem. If you want to fix the problem this way, you can use the serverless plugin to do it.

Yes, agreed

[monkeyDluffy6017]

@artlin760402 I will close this pr, looking forward to your next fix