feat: strictly validate the input of core resources #10233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sn0rt <[email protected]>
Comment on lines
-60
to
-66
| "uri": "/hello", | ||
| "upstream": { | ||
| "type": "roundrobin", | ||
| "nodes": { | ||
| "127.0.0.1:1980": 1 | ||
| } | ||
| }, |
There was a problem hiding this comment.
Why do you remove this?
There was a problem hiding this comment.
This field is not as expected and is not allowed to be passed into upstream in the global-rule.
_M.global_rule = {
type = "object",
properties = {
id = id_schema,
plugins = plugins_schema,
create_time = timestamp_def,
update_time = timestamp_def
},
required = {"id", "plugins"},
additionalProperties = false,
}There was a problem hiding this comment.
If you delete this block, the test case will fail
There was a problem hiding this comment.
I have test this PR on myself repo https://github.com/Sn0rt/apisix/pull/9
monkeyDluffy6017
approved these changes
Sep 20, 2023
AlinsRan
approved these changes
Sep 20, 2023
leslie-tsang
approved these changes
Sep 20, 2023
Sn0rt
changed the title
monkeyDluffy6017
changed the title
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10229
Checklist