feature: support multiple ports like stream listen in http and https listen port.

[wwd5613]

No description provided.

[membphis]

Very good advice

[moonming]

@wwd5613 welcome PR

[soulsoul]

@wwd5613 can u show some example？

[soulsoul]

that means: you want apisix can support multiple ports to start. now apisix just can start up on one port by the config parameter "node_listen ". just for the configuration in nginx
server {
listen 9080 9081 9082；
listen 9443 ssl https2;
}
is it right ?
@wwd5613

[tzssangglass]

I want to solve this issues. This is my first time to participate in apisix.
Can I choose @membphis as a mentor.
The deadline I gave is October 18.

[membphis]

@tzssangglass no problem. I have assigned this issue to you. If you have any questions, please feel free to talk to me.

[tzssangglass]

@tzssangglass no problem. I have assigned this issue to you. If you have any questions, please feel free to talk to me.

ok

[tzssangglass]

now i modified config.yaml as follows

apisix:
  node_listen:
    - 9080
    - 9081
    - 9082

and modified the ngx_tpl related places, as follows

        {% for _, port in ipairs(node_listen) do %}
        listen {* port *} {% if enable_reuseport then %} reuseport {% end %};
        {% end %}
        ……
        {% for _, port in ipairs(node_listen) do %}
        listen [::]:{* port *} {% if enable_reuseport then %} reuseport {% end %};
        {% end %}

in this way config.yaml can be parsed as the following configuration in nginx.conf

        listen 9080 reuseport;
        listen 9081 reuseport;
        listen 9082 reuseport;
        ……
        listen [::]:9080 reuseport;
        listen [::]:9081 reuseport;
        listen [::]:9082 reuseport;

now my question is

• Is it compatible with the original configuration of node_listen and separated by commas
• Expansion 9080 and 9443 port

[membphis]

support multiple listening ports, there are three styles:

style 1

apisix:
  node_listen:
    - 9080
    - 9081
    - 9082

style 2

apisix:
  node_listen: 9080 9081 9082

style 3

apisix:
  node_listen: 9080, 9081, 9082

Which is the one you would like?
I vote to 2 and 3.

[tzssangglass]

I vote to 3

• downward compatibility
• reduced ambiguity

[moonming]

Apache APISIX is now using style 1, I think it should be consistent, this is also a more common way in yaml

[tzssangglass]

Apache APISIX is now using style 1, I think it should be consistent, this is also a more common way in yaml

In master branch，node_listen is not using style 1，

apisix/conf/config-default.yaml

Lines 22 to 23 in b8e4b85

	apisix:
	node_listen: 9080 # APISIX listening port

but stream_proxy is using style 1，

apisix/conf/config-default.yaml

Lines 88 to 90 in b8e4b85

	# stream_proxy: # TCP/UDP proxy
	# tcp: # TCP proxy port list
	# - 9100

so without considering backward compatibility，node_listen change to style 1 is the most suitable.

the question now is whether to consider backward compatibility, i cannot make a decision on my own.

[tzssangglass]

Or take a more complicated method, compatible with the original configuration method. If you need to support multiple ports like stream listen in http and https listen port，modify config.yaml like style 1.

[membphis]

Apache APISIX is now using style 1,

APISIX is using style 2 or 3 (only one port) currently.

[tzssangglass]

I think the compatibility design is reasonable, I plan to do this.
If the user want to support multiple listen, they need to modify config.yaml like style 1