Skip to content

Commit

Permalink
fix doc and test
Browse files Browse the repository at this point in the history
  • Loading branch information
kingluo committed Jul 29, 2022
1 parent 3fdb55d commit dc1c895
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
4 changes: 2 additions & 2 deletions docs/en/latest/plugins/prometheus.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,9 @@ plugin_attr:
### Specifying `metrics`

For http request related metrics, you could specify extra labels, which match the nginx variables.
For http request related metrics, you could specify extra labels, which match the APISIX variables.

If you specify label for nonexist nginx variable, the label value would be "".
If you specify label for nonexist APISIX variable, the label value would be "".

Currently, only below metrics are supported:

Expand Down
4 changes: 1 addition & 3 deletions t/plugin/prometheus4.t
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,6 @@ plugin_attr:
- upstream_status: $upstream_status
--- request
GET /hello
--- error_code: 200
Expand All @@ -131,11 +130,10 @@ plugin_attr:
- dummy: $dummy
--- request
GET /hello
--- error_code: 200
=== TEST 6: fetch the prometheus metric data, with nil label
=== TEST 6: fetch the prometheus metric data, with nonexist ngx variable
--- request
GET /apisix/prometheus/metrics
--- response_body eval
Expand Down

0 comments on commit dc1c895

Please sign in to comment.