fix: run docker build separately #583
Open
+48
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nic-6443
reviewed
Feb 25, 2025
| runs-on: ubuntu-latest | ||
|
|
||
| build-arm64: | ||
| runs-on: buildjet-4vcpu-ubuntu-2204-arm |
There was a problem hiding this comment.
you can't use buildjet in apache repo
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
nic-6443
reviewed
Feb 25, 2025
There was a problem hiding this comment.
There are a few issues in the process of building the dev image:
- The built image relies on
api7/apisix-runtime:dev, which hasn't been updated for 5 months. It comes from https://github.com/api7/apisix-build-tools/blob/master/.circleci/config.yml, and I suspect this workflow is also not working anymore. Therefore, I hope to modifydebian-dev/Dockerfileto be the same asdebian/Dockerfile, so it no longer depends onapi7/apisix-runtime:dev. - You can temporarily modify the trigger conditions of this Workflow so that it can build once during a PR to verify that your modifications solve the problem, avoiding having to merge into the main branch each time before discovering issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.