Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line break formulas in comments cause page freezes #245

Closed
obiscr opened this issue Nov 8, 2024 · 10 comments
Closed

Line break formulas in comments cause page freezes #245

obiscr opened this issue Nov 8, 2024 · 10 comments

Comments

@obiscr
Copy link

obiscr commented Nov 8, 2024

Hey, I found an interesting bug.

If I enter a formula with line breaks in a comment, the page will freezes, and for others as well.

image

In fact, the moment I clicked Add Comment, the page was already frozen.

If anyone else visits this page, they will not be able to do anything on this page.

After a while, the browser showing a dialog

image

I checked the database, the data shows this.

image
@robinv8
Copy link
Contributor

robinv8 commented Nov 8, 2024

I'll follow up.

@robinv8
Copy link
Contributor

robinv8 commented Nov 8, 2024

I can't reproduce it, can you please tell me your steps in detail?

@obiscr
Copy link
Author

obiscr commented Nov 8, 2024

Ah, I forgot to mention that.

I've installed this plugins:

./answer_original build \
--with github.com/apache/incubator-answer-plugins/connector-github \
--with github.com/apache/incubator-answer-plugins/connector-google \
--with github.com/apache/incubator-answer-plugins/connector-basic \
--with github.com/apache/incubator-answer-plugins/editor-formula \
--with github.com/apache/incubator-answer-plugins/embed-basic

Here is the version
image

Can you try to reproduce after install these plugins.(Maybe the key is editor-formula plugin)

@obiscr
Copy link
Author

obiscr commented Nov 8, 2024

BTW, I checked the browser logs and the server logs and I didn't find any errors

@robinv8
Copy link
Contributor

robinv8 commented Nov 8, 2024

I want to know what you typed into the editor that caused it to freeze.

@obiscr
Copy link
Author

obiscr commented Nov 8, 2024

image

I mentioned it in the first image.

$$
\vec{P} = ma
$$

@robinv8
Copy link
Contributor

robinv8 commented Nov 8, 2024

Is it development mode?

@obiscr
Copy link
Author

obiscr commented Nov 8, 2024

I'm not sure, how do I check if I'm in development mode?

@robinv8
Copy link
Contributor

robinv8 commented Nov 8, 2024

Sorry, I asked a question that was incorrect. I'll check it out first.

robinv8 added a commit to apache/answer that referenced this issue Nov 13, 2024
LinkinStars pushed a commit to apache/answer that referenced this issue Dec 9, 2024
LinkinStars added a commit to sunshineg/incubator-answer that referenced this issue Dec 9, 2024
* docs(ui): add Apache license header to InitialLoadingPlaceholder components

* # Conflicts:
#	i18n/da_DK.yaml
#	i18n/de_DE.yaml
#	i18n/es_ES.yaml
#	i18n/fa_IR.yaml
#	i18n/fr_FR.yaml
#	i18n/it_IT.yaml
#	i18n/ko_KR.yaml
#	i18n/pl_PL.yaml
#	i18n/pt_PT.yaml
#	i18n/ro_RO.yaml
#	i18n/ru_RU.yaml
#	i18n/sv_SE.yaml
#	i18n/uk_UA.yaml
#	i18n/vi_VN.yaml
#	i18n/zh_CN.yaml

* docs(i18n): update translation progress

* docs(i18n): update translation

* docs(i18n): update translation progress

* docs(i18n): update translation

* ci(gorelease): Upgrade Goreleaser version to 2 and update snapshot version template

* ci(gorelease): Upgrade Goreleaser version to 2 and update snapshot version template

* ci(plugin): make default plugin list

* fix: missing js-sha256 license

* docs: update license files

* docs: rename codemirror license file name

* fix: fixed project initialization not allowing access to the plug-in interface, causing the page to continue loading apache#1162

* fix: delete unused log

* perf: optimize tag has new tag check

* fix: add status filter when update tag rel

* fix: wrong status when enable tag rel

* fix: resolve 404 error on Tags static page

* feat: update template files

* fix: display timezone on Dashboard when set to UTC

* fix: update useRenderHtmlPlugin to target specific HTML element

Related issue: apache/answer-plugins#245

* fix: Tag summary display is not as expected on tag detail page

* refactor(gomock): update gomock dependence and docs

* feat(file): update the max image size

* fix(review): reject the review when delete question

* fix: Markdown parsing without incrementing ordered list numbers

* feat: actions add toast tips

* perf: add note to email body

* feat: Add key metrics to the dashboard

* fix(search): fix the wrong offset when searching

* feat(question): add linked count feature to question

* feat(question): sort questions by update time for frequent tab

* feat(upload): add support for file attachments and enhance image upload

* feat: The editor has added support for uploading attachments, and the management background has added file upload configuration information.

* fix: Add file upload error handling

* feat(upload): add support for file attachments and enhance image upload

* fix: length error

* fix: Optimize the mobile style of QueryGroup component

* fix: Optimize the mobile style of QueryGroup component dropdown btns

* fix: The pre tag sets the maximum height apache#1168

* test: fix TestGetAvatarURL

* feat(storage): add upload file condition to plugin upload

* feat(user): add top questions and answers to user homepage

* fix: administrator add user failure

* fix: Attachment accept type adjustment, editor plug-in insertion position added conditional restrictions

* refactor: remove unused heading options and clean up icon styles

* refactor(i18n): update formatting instructions to mention post IDs

* feat(file): implement file download functionality

* refactor(uploader): improve file upload and download functionality subpath constants
- Adjust file download

* feat(upload): add support for attachment uploads and improve image handling

* feat: Add delete external user login info by user ID

* docs(Makefile): upgrade version to 1.4.2

---------

Co-authored-by: LinkinStars <[email protected]>
Co-authored-by: sy-records <[email protected]>
Co-authored-by: shuai <[email protected]>
Co-authored-by: Sonui <[email protected]>
Co-authored-by: robin <[email protected]>
Co-authored-by: wxt <[email protected]>
@sy-records
Copy link
Member

Fixed in v1.4.2-RC1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants