Fix side effect of not tearing down mongo hook in tests #46291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MongoClient apparently starts a separate thread that runs an active loop that performs sleep every 0.5 second. MongoClient is stored in the Hook and hooks/test_mongo.py stored the hook as object in the test class, which means that the thread has not been torn down and continued to run after mongo tests completed. Subsequently any test that was mocking time.sleep (and skipping waiting) had been spammed by mongo client thread calling sleep() - potentially many times. Earlier attempts to fix this had not succeeded - so they are reverted now as part of this PR, as the original patching of sleep was much nicer there. Revert "Make racy test test_start_pod_startup_interval_seconds less racy (apache#46282)" This reverts commit 60f0abf. Revert "Make azure test less flaky/racy (apache#46281)" This reverts commit ae55e22.
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
potiuk
requested review from
ashb,
Taragolis,
amoghrajesh,
eladkal and
jscheffl
potiuk
added
full tests needed
vincbeck
approved these changes
Jan 30, 2025
o-nikolas
approved these changes
Jan 30, 2025
|
It does WHAT? 🤯 |
Yep. 🤯 |
1 task
|
Wow, great catch! |
🐟 |
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
The MongoClient apparently starts a separate thread that runs an active loop that performs sleep every 0.5 second. MongoClient is stored in the Hook and hooks/test_mongo.py stored the hook as object in the test class, which means that the thread has not been torn down and continued to run after mongo tests completed. Subsequently any test that was mocking time.sleep (and skipping waiting) had been spammed by mongo client thread calling sleep() - potentially many times. Earlier attempts to fix this had not succeeded - so they are reverted now as part of this PR, as the original patching of sleep was much nicer there. Revert "Make racy test test_start_pod_startup_interval_seconds less racy (apache#46282)" This reverts commit 60f0abf. Revert "Make azure test less flaky/racy (apache#46281)" This reverts commit ae55e22.
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
The MongoClient apparently starts a separate thread that runs an active loop that performs sleep every 0.5 second. MongoClient is stored in the Hook and hooks/test_mongo.py stored the hook as object in the test class, which means that the thread has not been torn down and continued to run after mongo tests completed. Subsequently any test that was mocking time.sleep (and skipping waiting) had been spammed by mongo client thread calling sleep() - potentially many times. Earlier attempts to fix this had not succeeded - so they are reverted now as part of this PR, as the original patching of sleep was much nicer there. Revert "Make racy test test_start_pod_startup_interval_seconds less racy (apache#46282)" This reverts commit 60f0abf. Revert "Make azure test less flaky/racy (apache#46281)" This reverts commit ae55e22.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MongoClient apparently starts a separate thread that runs an active loop that performs sleep every 0.5 second. MongoClient is stored in the Hook and hooks/test_mongo.py stored the hook as object in the test class, which means that the thread has not been torn down and continued to run after mongo tests completed.
Subsequently any test that was mocking time.sleep (and skipping waiting) had been spammed by mongo client thread calling sleep() - potentially many times.
Earlier attempts to fix this had not succeeded - so they are reverted now as part of this PR, as the original patching of sleep was much nicer there.
Revert "Make racy test test_start_pod_startup_interval_seconds less racy (#46282)"
This reverts commit 60f0abf.
Revert "Make azure test less flaky/racy (#46281)"
This reverts commit ae55e22.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.