-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace caplog with patching log property in k8s tests #46273
Conversation
Look great! Thanks! |
Yes
Might be worth doing to get people aware/engaged.
Absolutely. Go ahead with that :) |
Since caplog is very vulnerable to side effects we remove it from k8s tests and replace it with patching the log property of the K8SHook. This should not be vulnerable to side-effects.
6dbfbf9
to
c0acea6
Compare
Since caplog is very vulnerable to side effects we remove it from k8s tests and replace it with patching the log property of the K8SHook. This should not be vulnerable to side-effects.
Since caplog is very vulnerable to side effects we remove it from k8s tests and replace it with patching the log property of the K8SHook. This should not be vulnerable to side-effects.
Since caplog is very vulnerable to side effects we remove it from k8s tests and replace it with patching the log property of the K8SHook. This should not be vulnerable to side-effects.
Amazing! I will make the engagement and will create follow-ups :) This was one of the things I always wanted to support and wished to make it happen 🥳 |
👀 👀 👀 👀 👀 |
Since caplog is very vulnerable to side effects we remove it from k8s tests and replace it with patching the log property of the K8SHook. This should not be vulnerable to side-effects.
Since caplog is very vulnerable to side effects we remove it from k8s tests and replace it with patching the log property of the K8SHook. This should not be vulnerable to side-effects.
Since caplog is very vulnerable to side effects we remove it from k8s tests and replace it with patching the log property of the K8SHook. This should not be vulnerable to side-effects.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.