Satisfy Mypy for Livy Hook #46157
Merged
Satisfy Mypy for Livy Hook #46157
+8
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
bugraoz93,
sunank200,
gopidesupavan and
jscheffl
The Livy Hook shows ... strange MyPy errors and hard to say why. First of all it incorrectly used multiple inheritance (BaseHook already inherist from LoggingMixin) but then it seems that mypy has been lost when it comes to fields available in the hook. Setting them directly (like it happens in other hooks deriving from HttpHook solves the MyPy issues.
potiuk
force-pushed
the
fix-mypy-errors-in-livy-hook
branch
from
44c4f36 to
dbdb1d4
Compare
gopidesupavan
approved these changes
Jan 28, 2025
|
passed tests :) |
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
The Livy Hook shows ... strange MyPy errors and hard to say why. First of all it incorrectly used multiple inheritance (BaseHook already inherist from LoggingMixin) but then it seems that mypy has been lost when it comes to fields available in the hook. Setting them directly (like it happens in other hooks deriving from HttpHook solves the MyPy issues.
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Jan 30, 2025
The Livy Hook shows ... strange MyPy errors and hard to say why. First of all it incorrectly used multiple inheritance (BaseHook already inherist from LoggingMixin) but then it seems that mypy has been lost when it comes to fields available in the hook. Setting them directly (like it happens in other hooks deriving from HttpHook solves the MyPy issues.
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
The Livy Hook shows ... strange MyPy errors and hard to say why. First of all it incorrectly used multiple inheritance (BaseHook already inherist from LoggingMixin) but then it seems that mypy has been lost when it comes to fields available in the hook. Setting them directly (like it happens in other hooks deriving from HttpHook solves the MyPy issues.
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
The Livy Hook shows ... strange MyPy errors and hard to say why. First of all it incorrectly used multiple inheritance (BaseHook already inherist from LoggingMixin) but then it seems that mypy has been lost when it comes to fields available in the hook. Setting them directly (like it happens in other hooks deriving from HttpHook solves the MyPy issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Livy Hook shows ... strange MyPy errors and hard to say why.
First of all it incorrectly used multiple inheritance (BaseHook already inherist from LoggingMixin) but then it seems that mypy has been lost when it comes to fields available in the hook. Setting them directly (like it happens in other hooks deriving from HttpHook solves the MyPy issues.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.