Retry K8s tests on failures #46064
Merged
Retry K8s tests on failures #46064
+140
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhamraj-git
force-pushed
the
k8s_tests
branch
from
1370ac3 to
d7dee31
Compare
|
Looks good. |
shubhamraj-git
requested review from
potiuk,
ashb and
jedcunningham
as code owners
potiuk
approved these changes
Jan 26, 2025
shubhamraj-git
changed the title
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jan 28, 2025
This reverts commit cffb3c8.
potiuk
reviewed
Jan 28, 2025
| @@ -447,7 +447,7 @@ def check_async_run_results( | |||
| from airflow_breeze.utils.docker_command_utils import fix_ownership_using_docker | |||
|
|
|||
| fix_ownership_using_docker() | |||
| sys.exit(1) | |||
There was a problem hiding this comment.
@shubhamraj-git -> yeah here, the problem is that that we usually exited here.
potiuk
reviewed
Jan 28, 2025
| @@ -458,6 +458,8 @@ def check_async_run_results( | |||
| for output in outputs: | |||
| Path(output.file_name).unlink(missing_ok=True) | |||
|
|
|||
| return tests_failed | |||
There was a problem hiding this comment.
The right solution here will be:
if tests_failed:
sys.exit(1)
The problem is that we do not check the result of check_async_run_results - the method was supposed to "sys.exit(1)` here rather than return False.
My bad I have not noticed it :(
potiuk
added a commit
that referenced
this pull request
Jan 28, 2025
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
This reverts commit cffb3c8.
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Jan 30, 2025
This reverts commit cffb3c8.
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
This reverts commit cffb3c8.
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
This reverts commit cffb3c8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We face a lot of K8s failures on CI, Which usually gets pass after re-run.
This PR allows it to re-run for specific number of times, default being 2 without manual intervention.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.