Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-84 - remove dry_run in post backfill tests #46001

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

rawwar
Copy link
Collaborator

@rawwar rawwar commented Jan 24, 2025

I noticed a dry_run argument being sent in creating backfill tests. It's not part of the request body as per

class BackfillPostBody(BaseModel):
"""Object used for create backfill request."""
dag_id: str
from_date: datetime
to_date: datetime
run_backwards: bool = False
dag_run_conf: dict = {}
reprocess_behavior: ReprocessBehavior = ReprocessBehavior.NONE
max_active_runs: int = 10

We can either add it to the model(but I don't see it being utilized by underlying functionality) or remove it from tests.

Found this issue while working on #44306

@rawwar rawwar requested a review from pierrejeambrun January 24, 2025 04:10
@rawwar rawwar marked this pull request as ready for review January 24, 2025 04:10
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed,thanks.

There is a dedicated endpoint for running backfills in dry_run mode.

@pierrejeambrun pierrejeambrun merged commit 96ca2a6 into apache:main Jan 24, 2025
52 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants