-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move standard, alibaba and common.sql provider to the new structure #45964
Conversation
cf9f7fc
to
e964e91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool :)
e964e91
to
2b1d299
Compare
Got some fixes in 🤞 . also found a few small things - now IDE integration works nicely with the providers in separate folders (it was broken for a few days for the new providers). |
Also found out that This is actually nice thing about this splitting - we will likely find out all the stuff where providers are still imported from core tests :) |
And there are still two things to fix I see :) |
@potiuk so far I'm seeing the same failures https://github.com/apache/airflow/actions/runs/12933644386/job/36073123320?pr=45974 |
On it. |
2b1d299
to
cff724e
Compare
OK. looks like I have to convert common.sql first - to make that one succeed |
I also accidentally added alibaba yesterday during demo 🤦 ... But since it's already migrated, I will leave it in - updated description and title. |
And added few more replacements (logo/ .pre-commit-config.yaml) that could also be automated easliy (standard provider did not have them - but alibaba did). |
5912b00
to
049521c
Compare
oh good catch, thanks Jarek, this move revealing good stuff. :) |
ah i see, yes indeed. |
049521c
to
12b2a6f
Compare
Yeah. I actually love to do these kinds of refactoring, they usually reval some |
12b2a6f
to
1dd2891
Compare
1dd2891
to
035bf6c
Compare
And we need to add Another step closer to get to the package split - @ashb |
15cadb9
to
796c207
Compare
This one also adds some missing steps in provider migration script. improves the output and instructions and make it more robust for various variations of provider features and usage of imports. With those changes `standard` provider was 100% moved automatically. Also common.sql needs to be added in order to migrate standard in order to build production image. Alibaba was added accidentally during demo at dev call so we are committing it as well since it is already migrated.
796c207
to
bb45cd7
Compare
Finally got it green... This single PR allowed me to trace and fix quite a number of small issues we had with moving to the "providers" and now to the "newer providers" strucuture... Next step will be to launch full-blown migration process :). |
…pache#45964) This one also adds some missing steps in provider migration script. improves the output and instructions and make it more robust for various variations of provider features and usage of imports. With those changes `standard` provider was 100% moved automatically. Also common.sql needs to be added in order to migrate standard in order to build production image. Alibaba was added accidentally during demo at dev call so we are committing it as well since it is already migrated.
…pache#45964) This one also adds some missing steps in provider migration script. improves the output and instructions and make it more robust for various variations of provider features and usage of imports. With those changes `standard` provider was 100% moved automatically. Also common.sql needs to be added in order to migrate standard in order to build production image. Alibaba was added accidentally during demo at dev call so we are committing it as well since it is already migrated.
…pache#45964) This one also adds some missing steps in provider migration script. improves the output and instructions and make it more robust for various variations of provider features and usage of imports. With those changes `standard` provider was 100% moved automatically. Also common.sql needs to be added in order to migrate standard in order to build production image. Alibaba was added accidentally during demo at dev call so we are committing it as well since it is already migrated.
This one also adds some missing steps in provider migration script. improves the output and instructions and make it more robust for various variations of provider features and usage of imports.
With those changes
standard
provider was 100% moved automatically.Also common.sql needs to be added in order to migrate standard in
order to build production image.
Alibaba was added accidentally during demo at dev call so we are
committing it as well since it is already migrated.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.