Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to FAB 4.5.3 #45874

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Upgrade to FAB 4.5.3 #45874

merged 1 commit into from
Jan 22, 2025

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jan 21, 2025


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk potiuk merged commit 573cd95 into apache:main Jan 22, 2025
156 checks passed
@potiuk potiuk deleted the upgrade-fab-4.5.3 branch January 22, 2025 08:57
Copy link

Backport failed to create: providers-fab/v1-5. View the failure log Run details

Status Branch Result
providers-fab/v1-5 Commit Link

You can attempt to backport this manually by running:

cherry_picker 573cd95 providers-fab/v1-5

This should apply the commit to the providers-fab/v1-5 branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

potiuk added a commit to potiuk/airflow that referenced this pull request Jan 22, 2025
(cherry picked from commit 573cd95)
potiuk added a commit that referenced this pull request Jan 22, 2025
dauinh pushed a commit to dauinh/airflow that referenced this pull request Jan 24, 2025
@utkarsharma2 utkarsharma2 added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jan 27, 2025
@vincbeck
Copy link
Contributor

@potiuk I am not sure this is possible. We might need to revert this one. Or maybe there is another solution I do not see. This PR introduces a bug in FAB auth manager, if you try to log in with wrong creds, the webserver will crash. The error is unsupported hash type scrypt. scrypt has been introduced in werkzeug in 2.3. Thus we need to set the minimum version of werkzeug to 2.3. When I do that, I got some conflict dependencies because connexion[flask] depends on werkzeug < 2.3. We would need then to upgrade connexion to 3, which is another story.

WDYT?

@potiuk
Copy link
Member Author

potiuk commented Jan 29, 2025

Oh that's a big bummer. I will see to it later today or tomorrow

gpathak128 pushed a commit to gpathak128/airflow that referenced this pull request Jan 29, 2025
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
niklasr22 pushed a commit to niklasr22/airflow that referenced this pull request Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers backport-to-providers-fab/v1-5 changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) provider:fab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants