Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back mypy checks for new-structure providers #45815

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jan 20, 2025

The providers moved to the news structure have not been chedked by mypy checks when run in "canary" or "full tests needed" builds. This change adds possibility to pass multiple folders to mypy check and adds special "all_new_providers" special argument that gets automatically resolved to all new provider folders.

Also few mypy checks started to appear and they are fixed now.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk potiuk requested a review from ashb as a code owner January 20, 2025 20:37
@potiuk potiuk force-pushed the add-new-providers-to-mypy-checks branch 2 times, most recently from 18ee091 to 9f7149e Compare January 20, 2025 20:51
@potiuk potiuk requested a review from XD-DENG as a code owner January 20, 2025 20:51
The providers moved to the news structure have not been chedked
by mypy checks when run in "canary" or "full tests needed" builds. This
change adds possibility to pass multiple folders to mypy check and adds
special "all_new_providers" special argument that gets automatically
resolved to all new provider folders.

Also few mypy checks started to appear and they are fixed now.
@potiuk potiuk force-pushed the add-new-providers-to-mypy-checks branch from 9f7149e to 7310d80 Compare January 20, 2025 21:09
@potiuk
Copy link
Member Author

potiuk commented Jan 20, 2025

Moar teething issues :)

@potiuk
Copy link
Member Author

potiuk commented Jan 20, 2025

Nice:

Screenshot 2025-01-20 at 22 44 25

@potiuk potiuk merged commit 2f3601d into apache:main Jan 20, 2025
61 checks passed
@potiuk potiuk deleted the add-new-providers-to-mypy-checks branch January 20, 2025 21:45
dauinh pushed a commit to dauinh/airflow that referenced this pull request Jan 24, 2025
The providers moved to the news structure have not been chedked
by mypy checks when run in "canary" or "full tests needed" builds. This
change adds possibility to pass multiple folders to mypy check and adds
special "all_new_providers" special argument that gets automatically
resolved to all new provider folders.

Also few mypy checks started to appear and they are fixed now.
gpathak128 pushed a commit to gpathak128/airflow that referenced this pull request Jan 29, 2025
The providers moved to the news structure have not been chedked
by mypy checks when run in "canary" or "full tests needed" builds. This
change adds possibility to pass multiple folders to mypy check and adds
special "all_new_providers" special argument that gets automatically
resolved to all new provider folders.

Also few mypy checks started to appear and they are fixed now.
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
The providers moved to the news structure have not been chedked
by mypy checks when run in "canary" or "full tests needed" builds. This
change adds possibility to pass multiple folders to mypy check and adds
special "all_new_providers" special argument that gets automatically
resolved to all new provider folders.

Also few mypy checks started to appear and they are fixed now.
niklasr22 pushed a commit to niklasr22/airflow that referenced this pull request Feb 8, 2025
The providers moved to the news structure have not been chedked
by mypy checks when run in "canary" or "full tests needed" builds. This
change adds possibility to pass multiple folders to mypy check and adds
special "all_new_providers" special argument that gets automatically
resolved to all new provider folders.

Also few mypy checks started to appear and they are fixed now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants