Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create new session in stuck queue reschedule handler #44192

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

dstandish
Copy link
Contributor

@dstandish dstandish commented Nov 19, 2024

This is a fix up / followup to #43520

It does not really make a material difference, just, I'm avoiding use of the session decorator, and the create / dispose session logic, when it is not needed. i also commit as i go along since there's no reason to handle multiple distinct tis in the same transaction.

cc @jscheffl

@boring-cyborg boring-cyborg bot added the area:Scheduler including HA (high availability) scheduler label Nov 19, 2024
@dstandish dstandish requested a review from jscheffl November 19, 2024 16:57
@dstandish dstandish added this to the Airflow 2.10.4 milestone Nov 19, 2024
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That totally makes sense!

@dstandish dstandish merged commit a825c95 into apache:main Nov 19, 2024
45 checks passed
@dstandish dstandish deleted the dont-create-new-session-requeue-fix branch November 19, 2024 21:49
LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025
)

This is a fix up / followup to apache#43520

It does not really make a material difference, just, I'm avoiding use of the session decorator, and the create / dispose session logic, when it is not needed. i also commit as i go along since there's no reason to handle multiple distinct tis in the same transaction.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Scheduler including HA (high availability) scheduler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants