-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove reference to undead tasks from documentation #43536
Conversation
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
@RNHTTR as discussed offline, the URL redirects were failing in my tests because redirecting sections doesn't work on Sphinx by only modifying redirects.txt. Therefore, I created redirects.js to dynamically handle URL fragment redirects. I built the docs and tested this out to confirm that it works. |
Any opposition to this @potiuk ? |
--------- Co-authored-by: Ryan Hatter <[email protected]>
--------- Co-authored-by: Ryan Hatter <[email protected]>
--------- Co-authored-by: Ryan Hatter <[email protected]>
--------- Co-authored-by: Ryan Hatter <[email protected]>
This PR removes references to undead tasks from the docs page here.
The term "undead task" is not used in the logs. Instead, if a running task has its state externally changed (what undead tasks is referring to in the docs), the logs display the below message where "x" is the new task state (source code).
There is no reference to undead tasks within this log message or anywhere else in Airflow (I think). Therefore, users do not search for the term "undead tasks" when they encounter this error. Including it in the documentation seems unhelpful and can even be confusing if users conflate it with zombie tasks.
Additionally, the line in the documentation above the code snippet states: "Below is the code snippet from the Airflow scheduler that runs periodically to detect zombie/undead tasks." This line is incorrect because the snippet only contains code for detecting zombies. The code to detect tasks whose state has been changed externally is in local_task_job_runner.py.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.