Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum version of google auth #40190

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jun 12, 2024

The #39873 added an implicit dependency to google auth > 2.29.0 because it uses SubjectTokenSupplier added in that version.

Our "Lowest-direct" tests caught it (yay!) so we should add the min requirement to the dependency.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

The apache#39873 added an implicit dependency to google auth > 2.29.0
because it uses SubjectTokenSupplier added in that version.

Our "Lowest-direct" tests caught it (yay!) so we should add the
min requirement to the dependency.
@potiuk potiuk requested a review from hussein-awala June 12, 2024 08:39
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Jun 12, 2024
@potiuk potiuk merged commit 23a0152 into apache:main Jun 12, 2024
102 of 103 checks passed
@potiuk potiuk deleted the bump-min-version-of-google-auth branch June 12, 2024 09:20
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
The apache#39873 added an implicit dependency to google auth > 2.29.0
because it uses SubjectTokenSupplier added in that version.

Our "Lowest-direct" tests caught it (yay!) so we should add the
min requirement to the dependency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants