-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Databricks: stop including user names in list_jobs
#40178
Databricks: stop including user names in list_jobs
#40178
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
0ee91c7
to
df3bc11
Compare
Isn't "false" default doing the same? |
@potiuk |
Right :D |
tests need fixing though |
The user's name is not used on the Airflow side, and this argument saves the lookup, which makes the request faster.
df3bc11
to
7ef3178
Compare
@potiuk thanks! I think the tests should pass now. |
Almost. BTW. Installing pre-commit and running them on the change should auto-fix all static errors. |
7ef3178
to
d21acac
Compare
@potiuk rectified now by running the pre-commit hooks, thank you for the guidance. |
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
* Databricks: stop including user names in `list_jobs` The user's name is not used on the Airflow side, and this argument saves the lookup, which makes the request faster.
When querying
list_jobs
, by default the owning user's name is resolved. This field is not used on the Airflow side, and the lookup is (relatively) expensive.With this new argument, the lookup is skipped. This will make requests faster and more reliable.