-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GCSToGCSOperator
behavior difference for moving single object
#40162
Conversation
I think this one requires at the very least some more explanation added to https://github.com/apache/airflow/blob/main/airflow/providers/google/CHANGELOG.rst It's on the border of breaking change, but we can also treat it as a bugfix, but we should have a user-targeted explanation on what they should do if they experience the problem. Could you please add such explanation at teh top of the Changelog? |
f0202a8
to
c4d92e7
Compare
Hi @potiuk, thanks for the feedback! I added a note about the change. It was a bit unclear without an example as it is a very specific case, so I also added a simple example to make it clear. LMK if I need to change anything. |
nice! |
…object (apache#40162)" This reverts commit 2f2796f.
…pache#40162) * Merge different behavior of `GCSToGCSOperator` for single and multiple objects * Add behavior change note to changelog
…object (apache#40162)" (apache#40577) This reverts commit 2f2796f.
GCSToGCSOperator
did not retain the nested folder structure when moving a single object. This PR merges the logic for single and multiple objects and handles folder structure similar to whatgsutil
does.closes: #37576
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.