[openlineage] Add error stacktrace to task fail event #39813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kacpermuda
force-pushed
the
ol-add-error-to-task-event
branch
3 times, most recently
from
ac64540 to
c1be45c
Compare
mobuchowski
reviewed
May 27, 2024
Signed-off-by: Kacper Muda <[email protected]>
kacpermuda
force-pushed
the
ol-add-error-to-task-event
branch
from
c1be45c to
989e07a
Compare
mobuchowski
approved these changes
May 29, 2024
fdemiane
pushed a commit
to fdemiane/airflow
that referenced
this pull request
Jun 6, 2024
Signed-off-by: Kacper Muda <[email protected]>
96 tasks
20 tasks
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
Signed-off-by: Kacper Muda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to #38155, starting from Airflow 2.10 listener will start receiving error in
on_task_instance_failed(). This PR adjust OpenLineage listener to attach this information using ErrorMessageRunFacet. As mentioned here, these changes in the code are required if we want to maintain the listener compatibility with previous Airflow versions as well.Also adjusting tests and removing one test that did not serve any purpose, as we mocked all the Airflow behaviour.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.