Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecations mssql #39734

Merged
merged 1 commit into from
Jun 1, 2024
Merged

Conversation

Bowrna
Copy link
Contributor

@Bowrna Bowrna commented May 21, 2024

Related: #39485
Removing deprecated MsSqlOperator from docs and tests and replacing with SQLExecuteQueryOperator


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Contributor

@dirrao dirrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@RNHTTR RNHTTR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should refer to the SQLExecuteQueryOperator?

@Bowrna Bowrna force-pushed the remove_deprecation_mssql branch from 412346a to dfa9ecb Compare May 22, 2024 00:31
@vincbeck
Copy link
Contributor

Please resolve conflict

@Bowrna Bowrna force-pushed the remove_deprecation_mssql branch from dfa9ecb to 21d20f8 Compare May 27, 2024 05:41
@Bowrna Bowrna force-pushed the remove_deprecation_mssql branch from 21d20f8 to cfa25b9 Compare June 1, 2024 08:20
@Bowrna
Copy link
Contributor Author

Bowrna commented Jun 1, 2024

I have resolved the conflicts in this PR

@potiuk potiuk merged commit 3af562f into apache:main Jun 1, 2024
50 checks passed
fdemiane pushed a commit to fdemiane/airflow that referenced this pull request Jun 6, 2024
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants