-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Teradata Provider #36953
Add Teradata Provider #36953
Conversation
…lytics and data platform Implemented new airflow provider with Hook, Operator and Transfer Operator
Hi Airflow Community, We've sent a proposal for Teradata being Airflow's new community provider. After 72 hours of voting, we have 9 positive votes (4 binding and 5 non-binding). Please review our PR and let us know if there's anything else you'd need from us. Thanks, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks clean! I will run the tests, let's wait for them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review for now
airflow/providers/teradata/example_dags/example_teradata_to_teradata_transfer_operator.py
Outdated
Show resolved
Hide resolved
airflow/providers/teradata/example_dags/example_teradata_operator.py
Outdated
Show resolved
Hide resolved
Addressed the review comments. |
Hi @SatishChGit, |
Thank you for this. We will check the possibility and will add in our roadmap. |
Hi @eladkal, have you had a chance to review the changes we did? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid work here! A few changes needed notwithstanding the example DAG question.
airflow/providers/teradata/example_dags/example_teradata_operator.py
Outdated
Show resolved
Hide resolved
airflow/providers/teradata/example_dags/example_teradata_operator.py
Outdated
Show resolved
Hide resolved
commit ade9ce3 Author: SatishChGit <[email protected]> Date: Wed Feb 14 01:04:46 2024 -0800 Redesigned teradatatoteradataoperator by removing private method
@airflow team, just following up on the changes we made. Could someone please review them? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Elad Kalif <[email protected]>
Addressed all review comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! A very minor comment for code snippet formatting in the docs, but that definitely doesn't deter from the work here.
Thank you for the review. Committed suggested change. |
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 |
Nice work @SatishChGit, congrats! |
Thank you, everyone, for your support! We truly appreciate it! |
🎉 🎉 Great work! |
Thank you every one for your support!. When is the airflow next release. After next airflow release, hope teradata provider will be listed at https://airflow.apache.org/docs/#active-providers. |
It will be in the next wave of providers for the release, or we can cut an ad-hoc one cc @eladkal |
Initial Implementation of Airflow Teradata Provider for Teradata - complete cloud analytics and data platform. As part of initial release, Added below functionalities.
Added required documentation, unit and system tests for Teradata Provider changes.
With this PR:
Teradata Provider System Test Health Board:
https://teradata.github.io/airflow/
Teradata Provider documentation build status: https://github.com/Teradata/airflow/actions/runs/7613734774
Teradata Provider static checks status: https://github.com/Teradata/airflow/actions/runs/7613748694/job/20734385279
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.