Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow SSHOperator.skip_on_exit_code to be zero #36358

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

dolfinus
Copy link
Contributor

@dolfinus dolfinus commented Dec 21, 2023

Allow for SSHOperator to skip task on successfully finished command by passing SSHOperator(skip_on_exit_code=0).

This is the result of discussion #36355 (review)


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@dolfinus dolfinus force-pushed the ssh-exit-code-allow-skip-0 branch from c087ee7 to 4421f4b Compare December 21, 2023 21:27
@dolfinus dolfinus marked this pull request as ready for review December 21, 2023 22:00
@hussein-awala hussein-awala merged commit e028e38 into apache:main Dec 21, 2023
52 checks passed
@hussein-awala hussein-awala added this to the Airflow 2.8.1 milestone Dec 21, 2023
@hussein-awala hussein-awala added the type:bug-fix Changelog: Bug Fixes label Dec 21, 2023
@dolfinus dolfinus deleted the ssh-exit-code-allow-skip-0 branch December 21, 2023 22:30
@jedcunningham jedcunningham removed this from the Airflow 2.9.0 milestone Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants