Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move duckdb & pandas import in tutorial DAG into task #35964

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

ephraimbuddy
Copy link
Contributor

This improves the code as per best practices and avoids import error if duckdb is not installed

@@ -62,9 +62,6 @@ def tutorial_objectstorage():
located
[here](https://airflow.apache.org/docs/apache-airflow/stable/tutorial/objectstorage.html)
"""
# [END instantiate_dag]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't used

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also remove start :) ?

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit.

This improves the code as per best practices and avoids import
error if duckdb is not installed
@bolkedebruin bolkedebruin merged commit f0ba2dc into apache:main Nov 30, 2023
@bolkedebruin
Copy link
Contributor

Makes sense!

@ephraimbuddy ephraimbuddy added this to the Airflow 2.8.0 milestone Dec 5, 2023
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Dec 5, 2023
ephraimbuddy added a commit that referenced this pull request Dec 5, 2023
This improves the code as per best practices and avoids import
error if duckdb is not installed

(cherry picked from commit f0ba2dc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants