Fix EC2Hook get_instance for client_type api #35960
Conversation
boring-cyborg
bot
added
area:providers
provider:amazon
| @@ -85,7 +85,7 @@ def get_instance(self, instance_id: str, filters: list | None = None): | |||
| :return: Instance object | |||
| """ | |||
| if self._api_type == "client_type": | |||
| return self.get_instances(filters=filters, instance_ids=[instance_id]) | |||
| return self.get_instances(filters=filters, instance_ids=[instance_id])[0] | |||
There was a problem hiding this comment.
Is not it breaking change? Or we consider it as bug fix?
There was a problem hiding this comment.
For me, it's a bug fix. We can check with @eladkal.
There was a problem hiding this comment.
The method seems to return a single instance with the default api_type="resource_type". Similarly, this method should return a single instance for other api_types, so I would treat it as a bug fix. Also, it's named as get_instance so the expectation would be a single instance to be returned.
There was a problem hiding this comment.
I would classify this as bug fix
| @@ -85,7 +85,7 @@ def get_instance(self, instance_id: str, filters: list | None = None): | |||
| :return: Instance object | |||
| """ | |||
| if self._api_type == "client_type": | |||
| return self.get_instances(filters=filters, instance_ids=[instance_id]) | |||
| return self.get_instances(filters=filters, instance_ids=[instance_id])[0] | |||
There was a problem hiding this comment.
The method seems to return a single instance with the default api_type="resource_type". Similarly, this method should return a single instance for other api_types, so I would treat it as a bug fix. Also, it's named as get_instance so the expectation would be a single instance to be returned.
|
Thanks to all of you! |
The method
get_instanceshould return a single instance and not a list.