Refactor cursor retrieval in PostgresHook. #35498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for efficient cursor type resolution and clearer error messaging.
potiuk
changed the title
|
NIT: (changed the name) It's refactotr, not optimisatio. It's llikely (not sure) lest optimized than previous code but indeed nicer. |
|
NIT: (changed the name) It's refactor, not optimisation :). It's llikely (not sure) lest optimized than previous code but indeed nicer. |
potiuk
approved these changes
Nov 7, 2023
|
I've just, hopefully, fixed the failing tests from the last time you approved by running the pre-commit (my bad for not running it earlier), @potiuk thanks for reviewing! :) |
potiuk
approved these changes
Nov 7, 2023
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
60 tasks
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Nov 10, 2023
* Improve cursor lookup in PostgresHook, Refactored to use a dictionary for efficient cursor type resolution and clearer error messaging. * Ran pre-commit that removed redundant spaces that doesn't match the format of code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the
_get_cursormethod for improved efficiency and error handling.The method now uses a dictionary for cursor type lookup, streamlining the addition of future cursor types and providing clearer error messages for invalid cursors.